Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #6002) [helm] add support for creating services for agent presets #6463

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 1, 2025

What does this PR do?

This PR introduces support for automatically creating Kubernetes services for specific Elastic Agent presets through the Helm chart. It adds a structured and scalable mechanism for managing and exposing agent instances within the Kubernetes cluster. This enhancement allows users to define service configurations (e.g., type, ports) for push-based integrations like NetFlow.

Key changes:

  1. Added logic in the Helm chart to generate services for agent presets when specified in values.yaml.
  2. Introduced configuration examples for creating a NodePort service linked to a NetFlow agent preset.
  3. Updated schema definitions in values.schema.json to support new service and port configuration options.

Why is it important?

This enhancement simplifies the deployment and operational management of push-based integrations by allowing users to define and scale agent services directly through Helm configurations. By enabling Kubernetes service generation, this change:

  • Streamlines access to agent instances.
  • Supports various service types (e.g., ClusterIP, NodePort, LoadBalancer) to accommodate diverse user needs.

Checklist

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files

Disruptive User Impact

This PR does not introduce disruptive changes, as service creation is optional and requires explicit configuration by users in values.yaml. By default, no services will be created unless configured.

How to test this PR locally

Follow the example introduced in this PR

Related issues

@mergify mergify bot added the backport label Jan 1, 2025
@mergify mergify bot requested a review from a team as a code owner January 1, 2025 11:36
@mergify mergify bot requested review from blakerouse and kaanyalti and removed request for a team January 1, 2025 11:36
@michalpristas
Copy link
Contributor

ping @pkoutsovasilis can you take a look at failures?

@pkoutsovasilis pkoutsovasilis enabled auto-merge (squash) January 2, 2025 11:58
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pkoutsovasilis pkoutsovasilis merged commit a9f8cf5 into 8.x Jan 2, 2025
9 checks passed
@pkoutsovasilis pkoutsovasilis deleted the mergify/bp/8.x/pr-6002 branch January 2, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants