You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces support for automatically creating Kubernetes services for specific Elastic Agent presets through the Helm chart. It adds a structured and scalable mechanism for managing and exposing agent instances within the Kubernetes cluster. This enhancement allows users to define service configurations (e.g., type, ports) for push-based integrations like NetFlow.
Key changes:
Added logic in the Helm chart to generate services for agent presets when specified in values.yaml.
Introduced configuration examples for creating a NodePort service linked to a NetFlow agent preset.
Updated schema definitions in values.schema.json to support new service and port configuration options.
Why is it important?
This enhancement simplifies the deployment and operational management of push-based integrations by allowing users to define and scale agent services directly through Helm configurations. By enabling Kubernetes service generation, this change:
Streamlines access to agent instances.
Supports various service types (e.g., ClusterIP, NodePort, LoadBalancer) to accommodate diverse user needs.
Checklist
My code follows the style guidelines of this project
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
Disruptive User Impact
This PR does not introduce disruptive changes, as service creation is optional and requires explicit configuration by users in values.yaml. By default, no services will be created unless configured.
This is true there is enough overlapping between the two, but there are enough small differences that make me wonder if merging them is gonna add value; namely deployment, statefulset, daemonset are ECK CRDs, the agent config (secret) is referenced in the CRD and all the mounts of that are handled by the ECK operator, thus, the pod template has a different flow. But sure in the future we could investigate merging them, does this make sense? 🙂
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces support for automatically creating Kubernetes services for specific Elastic Agent presets through the Helm chart. It adds a structured and scalable mechanism for managing and exposing agent instances within the Kubernetes cluster. This enhancement allows users to define service configurations (e.g., type, ports) for push-based integrations like NetFlow.
Key changes:
values.yaml.NodePortservice linked to a NetFlow agent preset.values.schema.jsonto support new service and port configuration options.Why is it important?
This enhancement simplifies the deployment and operational management of push-based integrations by allowing users to define and scale agent services directly through Helm configurations. By enabling Kubernetes service generation, this change:
ClusterIP,NodePort,LoadBalancer) to accommodate diverse user needs.Checklist
Disruptive User Impact
This PR does not introduce disruptive changes, as service creation is optional and requires explicit configuration by users in
values.yaml. By default, no services will be created unless configured.How to test this PR locally
Follow the example introduced in this PR
Related issues