Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17](backport #5799) Move back merged coverage report to build folder #6333

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 13, 2024

What does this PR do?

Restore the file location of the coverage report file back to /build folder.

Why is it important?

A recent commit change the generate coverage report file location and moved it from the /build to the root of the repo. This had a side effect on the Sonar scanning step that expected the file to be on the /build folder

Closes: https://github.com/elastic/ingest-dev/issues/4258


This is an automatic backport of pull request #5799 done by Mergify.

* Move back merged coverage report to build folder

A recent commit change the generate coverage report file location and
moved it from the `/build` to the root of the repo. This had a side
effect on the Sonar scanning step that expected the file to be on the
`/build` folder

Closes: https://github.com/elastic/ingest-dev/issues/4258
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>

* Fix the sonar step

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>

---------

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
(cherry picked from commit fc05e0d)
@mergify mergify bot added the backport label Dec 13, 2024
@mergify mergify bot requested a review from a team as a code owner December 13, 2024 16:54
Copy link
Contributor Author

mergify bot commented Dec 16, 2024

This pull request has not been merged yet. Could you please review and merge it @alexsapran? 🙏

Copy link
Contributor

@ev1yehor ev1yehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev1yehor ev1yehor merged commit d77d9ee into 8.17 Dec 17, 2024
5 of 7 checks passed
@ev1yehor ev1yehor deleted the mergify/bp/8.17/pr-5799 branch December 17, 2024 18:21
@ev1yehor
Copy link
Contributor

Force merged. Changes in PR not related to error in pipeline.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants