Move back merged coverage report to build folder #5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit change the generate coverage report file location and moved it from the `/build` to the root of the repo. This had a side effect on the Sonar scanning step that expected the file to be on the `/build` folder Closes: elastic/ingest-dev#4258 Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
|
This pull request does not have a backport label. Could you fix it @alexsapran? 🙏
|
|
|
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
|
|
See the build https://buildkite.com/elastic/elastic-agent/builds/13168#01929440-74f7-45b6-a79f-4bc63daa3e09/108-225 It worked. |
rowlandgeoff
approved these changes
Oct 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Move back merged coverage report to build folder A recent commit change the generate coverage report file location and moved it from the `/build` to the root of the repo. This had a side effect on the Sonar scanning step that expected the file to be on the `/build` folder Closes: https://github.com/elastic/ingest-dev/issues/4258 Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> * Fix the sonar step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> --------- Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit fc05e0d)
rdner
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Move back merged coverage report to build folder A recent commit change the generate coverage report file location and moved it from the `/build` to the root of the repo. This had a side effect on the Sonar scanning step that expected the file to be on the `/build` folder Closes: https://github.com/elastic/ingest-dev/issues/4258 Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> * Fix the sonar step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> --------- Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit fc05e0d) Co-authored-by: Alexandros Sapranidis <alexandros@elastic.co>
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Move back merged coverage report to build folder A recent commit change the generate coverage report file location and moved it from the `/build` to the root of the repo. This had a side effect on the Sonar scanning step that expected the file to be on the `/build` folder Closes: https://github.com/elastic/ingest-dev/issues/4258 Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> * Fix the sonar step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> --------- Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit fc05e0d)
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Move back merged coverage report to build folder A recent commit change the generate coverage report file location and moved it from the `/build` to the root of the repo. This had a side effect on the Sonar scanning step that expected the file to be on the `/build` folder Closes: https://github.com/elastic/ingest-dev/issues/4258 Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> * Fix the sonar step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> --------- Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit fc05e0d)
This was referenced Dec 13, 2024
ev1yehor
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Move back merged coverage report to build folder A recent commit change the generate coverage report file location and moved it from the `/build` to the root of the repo. This had a side effect on the Sonar scanning step that expected the file to be on the `/build` folder Closes: https://github.com/elastic/ingest-dev/issues/4258 Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> * Fix the sonar step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> --------- Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit fc05e0d) Co-authored-by: Alexandros Sapranidis <alexandros@elastic.co>
ev1yehor
added a commit
that referenced
this pull request
Dec 17, 2024
* Move back merged coverage report to build folder A recent commit change the generate coverage report file location and moved it from the `/build` to the root of the repo. This had a side effect on the Sonar scanning step that expected the file to be on the `/build` folder Closes: https://github.com/elastic/ingest-dev/issues/4258 Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> * Fix the sonar step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> --------- Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit fc05e0d) Co-authored-by: Alexandros Sapranidis <alexandros@elastic.co> Co-authored-by: Yehor Shvedov <146825775+ev1yehor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restore the file location of the coverage report file back to
/buildfolder.Why is it important?
A recent commit change the generate coverage report file location and moved it from the
/buildto the root of the repo. This had a side effect on the Sonar scanning step that expected the file to be on the/buildfolderCloses: https://github.com/elastic/ingest-dev/issues/4258