[8.x](backport #5939) [helm] derive the lease name from the release and preset names #5945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR disables by default the kubernetes leader election unless a user explicitly marks it as enabled. More importantly this PR sets the lease name from the Helm release and the agent preset names and thus different agent deployments won't utilise the same lease now.
Why is it important?
Because it guarantees correct lease isolation across different agent deployments in the same namespace
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
N/A
How to test this PR locally
follow the kubernetes example and do two installations of the Helm chart with a different release name and under the same namespace (leases are namespace-scoped). With this PR you will see that two leases are created for the
clusterWide
preset where before there would be only oneRelated issues
This is an automatic backport of pull request [helm] derive the lease name from the release and preset names #5939 done by Mergify.