Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] derive the lease name from the release and preset names #5939

Merged

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented Nov 5, 2024

What does this PR do?

This PR disables by default the kubernetes leader election unless a user explicitly marks it as enabled. More importantly this PR sets the lease name from the Helm release and the agent preset names and thus different agent deployments won't utilise the same lease now.

Why is it important?

Because it guarantees correct lease isolation across different agent deployments in the same namespace

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

N/A

How to test this PR locally

follow the kubernetes example and do two installations of the Helm chart with a different release name and under the same namespace (leases are namespace-scoped). With this PR you will see that two leases are created for the clusterWide preset where before there would be only one

Related issues

@pkoutsovasilis pkoutsovasilis added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Nov 5, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this Nov 5, 2024
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner November 5, 2024 10:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pkoutsovasilis pkoutsovasilis merged commit 20920ab into elastic:main Nov 5, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Nov 5, 2024
… the release and preset names (#5939)

(cherry picked from commit 20920ab)
mergify bot pushed a commit that referenced this pull request Nov 5, 2024
… the release and preset names (#5939)

(cherry picked from commit 20920ab)
pkoutsovasilis added a commit that referenced this pull request Nov 6, 2024
… the release and preset names (#5939) (#5944)

(cherry picked from commit 20920ab)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis added a commit that referenced this pull request Nov 7, 2024
… the release and preset names (#5939) (#5945)

(cherry picked from commit 20920ab)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
oakrizan pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants