-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm] derive the lease name from the release and preset names #5939
Merged
pkoutsovasilis
merged 1 commit into
elastic:main
from
pkoutsovasilis:helm/specify_lease_name
Nov 5, 2024
Merged
[helm] derive the lease name from the release and preset names #5939
pkoutsovasilis
merged 1 commit into
elastic:main
from
pkoutsovasilis:helm/specify_lease_name
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the release and preset names
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
swiatekm
reviewed
Nov 5, 2024
|
swiatekm
approved these changes
Nov 5, 2024
7 tasks
7 tasks
oakrizan
pushed a commit
that referenced
this pull request
Nov 7, 2024
… the release and preset names (#5939)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.x
Automated backport to the 8.x branch with mergify
backport-8.16
Automated backport with mergify
enhancement
New feature or request
skip-changelog
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR disables by default the kubernetes leader election unless a user explicitly marks it as enabled. More importantly this PR sets the lease name from the Helm release and the agent preset names and thus different agent deployments won't utilise the same lease now.
Why is it important?
Because it guarantees correct lease isolation across different agent deployments in the same namespace
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
N/A
How to test this PR locally
follow the kubernetes example and do two installations of the Helm chart with a different release name and under the same namespace (leases are namespace-scoped). With this PR you will see that two leases are created for the
clusterWide
preset where before there would be only oneRelated issues