Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5768) test: replace crypto/md5 usage with sha512 #5769

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 11, 2024

What does this PR do?

replace crypto/md5 usage with sha512
this is only used in tests to generate a unique id.
use sum384 since we need at most 63 chars

Why is it important?

crypto/md5 should not be used and might no be available in specific toolchains/envs

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #5768 done by [Mergify](https://mergify.com).

this is only used in tests and to generate a unique id
use sum384 since we need at most 63 chars

(cherry picked from commit a24fe4f)
@mergify mergify bot requested a review from a team as a code owner October 11, 2024 22:50
@mergify mergify bot added the backport label Oct 11, 2024
@mergify mergify bot requested review from michel-laterman and swiatekm and removed request for a team October 11, 2024 22:50
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert merged commit 7a40277 into 8.x Oct 13, 2024
15 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.x/pr-5768 branch October 13, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants