Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace crypto/md5 usage with sha512 #5768

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

kruskall
Copy link
Member

What does this PR do?

replace crypto/md5 usage with sha512
this is only used in tests to generate a unique id.
use sum384 since we need at most 63 chars

Why is it important?

crypto/md5 should not be used and might no be available in specific toolchains/envs

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

this is only used in tests and to generate a unique id
use sum384 since we need at most 63 chars
@kruskall kruskall requested a review from a team as a code owner October 11, 2024 20:46
Copy link
Contributor

mergify bot commented Oct 11, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Oct 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 11, 2024
@kruskall kruskall enabled auto-merge (squash) October 11, 2024 21:08
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kruskall kruskall merged commit a24fe4f into elastic:main Oct 11, 2024
14 of 16 checks passed
@kruskall kruskall deleted the test/drop-md5 branch October 11, 2024 22:49
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
this is only used in tests and to generate a unique id
use sum384 since we need at most 63 chars

(cherry picked from commit a24fe4f)
pierrehilbert pushed a commit that referenced this pull request Oct 13, 2024
this is only used in tests and to generate a unique id
use sum384 since we need at most 63 chars

(cherry picked from commit a24fe4f)

Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants