Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5621) redact secret_paths from elastic-agent inspect output #5721

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2024

What does this PR do?

redact secret_paths from elastic-agent inspect output.
elastic-agent inspect will now redact the value for any key in the secret_paths array.
secret_paths is expected to be part of the policy.

Why is it important?

displaying secrets is to be avoided

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

Output of elastic-agent inspect will change. Any workflow that uses this command to extract secret values will be broken.


This is an automatic backport of pull request #5621 done by Mergify.

redact secret_paths from elastic-agent inspect output.
elastic-agent inspect will now redact the value for any key in the secret_paths array.
secret_paths is expected to be part of the policy.

(cherry picked from commit d7546dd)
@mergify mergify bot requested a review from a team as a code owner October 7, 2024 15:55
@mergify mergify bot removed the request for review from a team October 7, 2024 15:55
@mergify mergify bot added the backport label Oct 7, 2024
@mergify mergify bot requested review from michel-laterman and swiatekm October 7, 2024 15:55
@michel-laterman michel-laterman enabled auto-merge (squash) October 7, 2024 18:43
@michel-laterman michel-laterman merged commit f86bda2 into 8.x Oct 7, 2024
14 checks passed
@michel-laterman michel-laterman deleted the mergify/bp/8.x/pr-5621 branch October 7, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants