-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redact secret_paths from elastic-agent inspect output #5621
redact secret_paths from elastic-agent inspect output #5621
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
|
|
7ea1e70
to
ea7eead
Compare
@lucabelluccini Heads up for Support on the disruptive user impact due to this change. |
ea7eead
to
4397d53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and has good test coverage.
Rerunning the failed Sonar steps in the PR got this unblocked |
Looks like an integration test is failing:
|
|
redact secret_paths from elastic-agent inspect output. elastic-agent inspect will now redact the value for any key in the secret_paths array. secret_paths is expected to be part of the policy. (cherry picked from commit d7546dd)
redact secret_paths from elastic-agent inspect output. elastic-agent inspect will now redact the value for any key in the secret_paths array. secret_paths is expected to be part of the policy. (cherry picked from commit d7546dd) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: Julien Lind <julien.lind@elastic.co>
What does this PR do?
redact secret_paths from elastic-agent inspect output.
elastic-agent inspect
will now redact the value for any key in thesecret_paths
array.secret_paths
is expected to be part of the policy.Why is it important?
displaying secrets is to be avoided
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragments
using the changelog toolDisruptive User Impact
Output of
elastic-agent inspect
will change. Any workflow that uses this command to extract secret values will be broken.