-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip failing k8s capabilities test #5293
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
NOTE: |
is this PR needed, given that there is this one open? 🙂 |
Being that this PR #5290 fixes the actual issue I would prefer to have it merged and have this on closed. |
Hi @ycombinator 👋 I think in one CI run (here) you got a failure because the chmoding of the parallel k8s tests (3 kind k8s clusters) were overwhelming the underline machine. Thus I have opened this PR against this branch which essentially makes the k8s integration test run in sequence and increase the timeout of waiting for elastic-agent to report healthy to 120 seconds. Please either cherry pick them from there or merge the PR, I have no issue and include them here. After syncing with @blakerouse and @cmacknz we decided that they best way forward is to unblock the CI for everybody by bringing in your PR first. Afterwards we will get some eyes from the Heartbeat team on the other PR, revert the Agentbeat capabilities PR, and if everything checks out we will merge it 🙂 |
Skip k8s caps test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ty @ycombinator
Ugh, now |
This is expected atm right based on this #5279 ?!
Also it increases the timeout here maybe we should bring these changes here? |
Thanks @pkoutsovasilis. I'm going to force merge this PR then and we'll deal with #5279 in a separate PR. That way we can revert the two PRs independently as we fix the respective tests for real. |
What does this PR do?
This PR skips the failing
TestKubernetesAgentStandalone/drop_ALL_add_CHOWN,_SETPCAP_capabilities_-_rootless_agent
integration test while it's being fixed.Why is it important?
To unblock Agent PRs that are failing CI only due to this test's failure.