Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing k8s capabilities test #5293

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

This PR skips the failing TestKubernetesAgentStandalone/drop_ALL_add_CHOWN,_SETPCAP_capabilities_-_rootless_agent integration test while it's being fixed.

Why is it important?

To unblock Agent PRs that are failing CI only due to this test's failure.

@ycombinator ycombinator added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog Testing skipped-test This change disables one or multiple tests labels Aug 13, 2024
@ycombinator ycombinator requested a review from a team as a code owner August 13, 2024 15:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

mergify bot commented Aug 13, 2024

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@pkoutsovasilis
Copy link
Contributor

is this PR needed, given that there is this one open? 🙂

@ycombinator
Copy link
Contributor Author

is this PR needed, given that there is this one open? 🙂

Whichever one goes in first, and would definitely prefer for that to be #5290 instead of this one 🙂.

@cmacknz cmacknz mentioned this pull request Aug 13, 2024
3 tasks
@blakerouse
Copy link
Contributor

Being that this PR #5290 fixes the actual issue I would prefer to have it merged and have this on closed.

@ycombinator
Copy link
Contributor Author

ycombinator commented Aug 13, 2024

Being that this PR #5290 fixes the actual issue I would prefer to have it merged and have this on closed.

Agreed. Will wait to merge this PR and close it unmerged if #5290 gets merged within the next few hours.

@pkoutsovasilis
Copy link
Contributor

pkoutsovasilis commented Aug 13, 2024

Hi @ycombinator 👋 I think in one CI run (here) you got a failure because the chmoding of the parallel k8s tests (3 kind k8s clusters) were overwhelming the underline machine. Thus I have opened this PR against this branch which essentially makes the k8s integration test run in sequence and increase the timeout of waiting for elastic-agent to report healthy to 120 seconds. Please either cherry pick them from there or merge the PR, I have no issue and include them here. After syncing with @blakerouse and @cmacknz we decided that they best way forward is to unblock the CI for everybody by bringing in your PR first. Afterwards we will get some eyes from the Heartbeat team on the other PR, revert the Agentbeat capabilities PR, and if everything checks out we will merge it 🙂

Copy link

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ty @ycombinator

@ycombinator
Copy link
Contributor Author

Ugh, now TestLongRunningAgentForLeaks/TestHandleLeak is failing :(

@pkoutsovasilis
Copy link
Contributor

pkoutsovasilis commented Aug 14, 2024

This is expected atm right based on this #5279 ?!
In this PR which was previously open, although the title and description is hinting only at k8s tests failures, it was disabling also some tests that I think overlap with what you are seeing here

Also it increases the timeout here

maybe we should bring these changes here?

@ycombinator
Copy link
Contributor Author

Thanks @pkoutsovasilis. I'm going to force merge this PR then and we'll deal with #5279 in a separate PR. That way we can revert the two PRs independently as we fix the respective tests for real.

@ycombinator ycombinator merged commit ddde355 into elastic:main Aug 14, 2024
10 of 13 checks passed
@ycombinator ycombinator deleted the skip-k8s-caps-test branch August 14, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip skip-changelog skipped-test This change disables one or multiple tests Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants