-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker][agentbeat]: add cap_sys_ptrace and cap_dac_override in permitted set #5271
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request does not have a backport label. Could you fix it @VihasMakwana? 🙏
NOTE: |
The CI is expected to fail until elastic/beats#40466 gets merged and released as a snapshot. |
Hi @VihasMakwana, just to confirm, are the changes in this PR intended to fix the following k8s integration test currently failing in CI?
[EDIT] Never mind, I see now that you need this PR and elastic/beats#40466 both to fix these tests. Created #5275 to track the test failure and mentioned both PRs in there. |
/test |
@@ -531,7 +531,7 @@ | |||
} | |||
}, | |||
{ | |||
"enabled": true, | |||
"enabled": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these being disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michel-laterman i actually forgot to update the description. my bad
Please take a look now.
/test |
|
Test failure is caused by #4215 |
@@ -57,7 +57,7 @@ RUN true && \ | |||
|
|||
# Keep this after any chown command, chown resets any applied capabilities | |||
RUN setcap =p {{ $beatHome }}/data/elastic-agent-{{ commit_short }}/elastic-agent | |||
RUN setcap cap_net_raw,cap_setuid+p {{ $beatHome }}/data/elastic-agent-{{ commit_short }}/components/agentbeat && \ | |||
RUN setcap cap_net_raw,cap_setuid,cap_sys_ptrace,cap_dac_override+p {{ $beatHome }}/data/elastic-agent-{{ commit_short }}/components/agentbeat && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dac_override
is way too open why dac_read_search
is not adequate?
is this PR really needed? given there is this one |
Vihas is out on PTO. I am going to pre-emptively close this assuming we don't need it and we can revisit later if needed. |
What does this PR do?
Grant cap_sys_ptrace and cap_dac_override to permitted set.
Required to operate in unprivileged mode.
This PR also updates k8s standalone tests and adds required permissions and disables the long running test case #5279.
I'm including all of these changes in the same PR because they are related to a same problem.
Why is it important?
Checklist
./changelog/fragments
using the changelog toolHow to test this PR locally
PACKAGES=docker mage package
on this branchRelated issues
agentbeat
causes agent degradation #5269