Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish rename started in #4562 #4676

Merged
merged 1 commit into from
May 6, 2024
Merged

Finish rename started in #4562 #4676

merged 1 commit into from
May 6, 2024
+5 −5

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented May 6, 2024 •
edited
Loading

Rename from #4562 skipped few places now tests are failing on:


Error: failed to determine batches: error running go test: (exit status 1), got:
# github.com/elastic/elastic-agent/testing/integration [github.com/elastic/elastic-agent/testing/integration.test]
testing/integration/diagnostics_test.go:161:25: undefined: define.NewFixture
testing/integration/diagnostics_test.go:210:19: undefined: define.NewFixture
testing/integration/fake_test.go:141:19: undefined: define.NewFixture
testing/integration/monitoring_probe_preserve_text_cfg_test.go:94:25: undefined: define.NewFixture
testing/integration/monitoring_probe_reload_test.go:59:25: undefined: define.NewFixture
FAIL	github.com/elastic/elastic-agent/testing/integration [build failed]

cc @belimawr @ycombinator

@michalpristas michalpristas added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team backport-skip skip-changelog labels May 6, 2024
@michalpristas michalpristas self-assigned this May 6, 2024
@michalpristas michalpristas requested a review from a team as a code owner May 6, 2024 07:53
@michalpristas michalpristas requested review from blakerouse and pchila May 6, 2024 07:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@michalpristas michalpristas changed the title Finish renamed started in #4562 Finish rename started in #4562 May 6, 2024
andrzej-stencel
andrzej-stencel approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙃

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@michalpristas michalpristas merged commit 8bc9e8f into elastic:main May 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@michalpristas michalpristas

Labels
backport-skip bug Something isn't working skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalpristas @elasticmachine @jlind23 @andrzej-stencel