Rename define.NewFixture to define.NewFixtureFromLocalBuild #4562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename define.NewFixture to define.NewFixtureFromLocalBuild
Why is it important?
There were two
NewFixture
functions returning the same fixture:testing.NewFixture
anddefine.NewFixture
. They basically differ on where the agent package comes from. This is rather confusing and easily lead to mistakes.testing.NewFixture
is the one which actually creates the fixture, whereasdefine.NewFixture
is a wrapper aroundtesting.NewFixture
so it'll use the locally built agent artifact. Thereforedefine.NewFixture
was renamed todefine.NewFixtureFromLocalBuild
, better reflecting what it does.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testRelated issues
Questions to ask yourself