Fix Windows flaky test TestComponentBuildHashInDiagnostics #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
NOTE: |
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
pchila
approved these changes
Feb 7, 2024
| isHealth, | ||
| 1*time.Minute, 10*time.Second, | ||
| allHealthy, | ||
| 5*time.Minute, 10*time.Second, | ||
| "agent did not became health. Last status: %v", &stateBuff) |
There was a problem hiding this comment.
Suggested change
| "agent did not became health. Last status: %v", &stateBuff) | |
| "agent never became healthy. Last status: %v", &stateBuff) |
| state := client.State(c.State) | ||
| if state != client.Healthy { | ||
| allHealthy = false | ||
| stateBuff.WriteString(fmt.Sprintf("%s not health, state: %s", |
There was a problem hiding this comment.
Nitpick: couldn't you just track the last status and dump that if the assertion fails? I understand that it would be bigger but it's a test and if it fails the more information we have, the better...
|
0.0% Duplication on New Code
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the test integration test TestComponentBuildHashInDiagnostics to wait all components to be healthy after agent installation before proceeding with the test.
Why is it important?
The test is flaky on windows because the components take too long to be healthy and report back their
version_infoChecklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog tool-~~ [ ] I have added an integration test or an E2E test~~
How to test this PR locally
Related issues
Questions to ask yourself