Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky integration test TestComponentBuildHashInDiagnostics #4218

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

AndersonQ
Copy link
Member

@AndersonQ AndersonQ commented Feb 7, 2024

What does this PR do?

Skip flaky integration test TestComponentBuildHashInDiagnostics

Why is it important?

The test is flaky

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@AndersonQ AndersonQ self-assigned this Feb 7, 2024
@AndersonQ AndersonQ requested a review from a team as a code owner February 7, 2024 13:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@AndersonQ AndersonQ enabled auto-merge (squash) February 7, 2024 13:55
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@pchila pchila added the skipped-test This change disables one or multiple tests label Feb 7, 2024
Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndersonQ AndersonQ removed the request for review from blakerouse February 7, 2024 14:56
@AndersonQ AndersonQ merged commit 6360d55 into elastic:main Feb 7, 2024
13 checks passed
@rdner
Copy link
Member

rdner commented Mar 22, 2024

The test was re-enabled by #4219

@rdner rdner removed the skipped-test This change disables one or multiple tests label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants