Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload artifacts action #2382

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Update upload artifacts action #2382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e5c33e
update version and debug
gurevichdmitry Aug 4, 2024
86b3eae
remove node selector
gurevichdmitry Aug 4, 2024
f45d2be
update values
gurevichdmitry Aug 4, 2024
1521051
revert debug changes
gurevichdmitry Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/actions/docker-images/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ runs:

- if: ${{ inputs.build-docker-images == 'true' }}
name: Upload docker images
uses: actions/upload-artifact@v4
# Pin action version to 4.3.4 See https://github.com/actions/upload-artifact/issues/589
uses: actions/upload-artifact@v4.3.4
with:
name: docker-images
path: ${{ inputs.docker-images-folder }}
Expand Down
4 changes: 1 addition & 3 deletions tests/test_environments/k8s-cloudbeat-tests/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ replicaCount: 1
image:
name: cloudbeat-test
repository: cloudbeat-test
pullPolicy: Always
pullPolicy: IfNotPresent
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For k8s tests, the images are loaded to the nodes locally, so the pull policy should be IfNotPresent.

# Overrides the image tag whose default is the chart appVersion.
tag: "latest"
ecr: 391946104644.dkr.ecr.eu-west-2.amazonaws.com
Expand Down Expand Up @@ -125,8 +125,6 @@ elasticsearch:

protocol: http

nodeSelector:
"elasticsearch-node": "true"

xpackSecurity:
enabled: false
Expand Down
Loading