Update upload artifacts action #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @gurevichdmitry? 🙏
|
📊 Allure Report - 💚 No failures were reported.
|
orouz
approved these changes
Aug 4, 2024
gurevichdmitry
commented
Aug 4, 2024
| @@ -7,7 +7,7 @@ replicaCount: 1 | |||
| image: | |||
| name: cloudbeat-test | |||
| repository: cloudbeat-test | |||
| pullPolicy: Always | |||
| pullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
For k8s tests, the images are loaded to the nodes locally, so the pull policy should be IfNotPresent.
|
@oren-zohar, since the tests are using |
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
(cherry picked from commit cb6ece0) # Conflicts: # tests/test_environments/k8s-cloudbeat-tests/values.yaml
5 tasks
moukoublen
added a commit
that referenced
this pull request
Oct 17, 2024
* Update upload artifacts action (#2382) (cherry picked from commit cb6ece0) # Conflicts: # tests/test_environments/k8s-cloudbeat-tests/values.yaml * conflict fix --------- Co-authored-by: Dmitry Gurevich <99176494+gurevichdmitry@users.noreply.github.com> Co-authored-by: Kostas Stamatakis <moukoublen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
This PR pins the upload artifacts version to v4.3.4 due to this bug and also fixes the k8s CI.
Screenshot/Data
Related Issues
Checklist
Introducing a new rule?