-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore context cancell in status reporting #27668
Merged
michalpristas
merged 1 commit into
elastic:master
from
michalpristas:fix/ignore-cancelled-app
Sep 2, 2021
Merged
Ignore context cancell in status reporting #27668
michalpristas
merged 1 commit into
elastic:master
from
michalpristas:fix/ignore-cancelled-app
Sep 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
bug
Team:Elastic-Agent
Label for the Agent team
backport-v7.15.0
Automated backport with mergify
backport-v7.16.0
Automated backport with mergify
labels
Aug 31, 2021
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Aug 31, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
blakerouse
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
michalpristas
changed the title
ignore context cancell in status reporting
Ignore context cancell in status reporting
Sep 2, 2021
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
(cherry picked from commit d601e3f)
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
(cherry picked from commit d601e3f)
michalpristas
added a commit
that referenced
this pull request
Sep 2, 2021
michalpristas
added a commit
that referenced
this pull request
Sep 2, 2021
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v7.15.0
Automated backport with mergify
backport-v7.16.0
Automated backport with mergify
bug
Team:Elastic-Agent
Label for the Agent team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Followup to #27210
This PR reduces context cancelled from status reporting including cases when process itself reports failure due to context cancelled.
Result is that two messages described in a comment linked below will disappear.
These does not alter behaviour and occur just at the time of restarting. But it may look like there's something wrong with process, operator or agent itself as failures propagate up.
Why is it important?
Fixes: #27062 (comment)
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.