Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore context cancelled in operator #27210

Merged

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

This PR guards HandleConfig func with filter resulting in ignoring context.Canceled errors.
Ignoring does not have any functional impact but it avoids spamming logs with false failures.

Why is it important?

Fixes: #27057

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug Team:Elastic-Agent Label for the Agent team backport-v7.15.0 Automated backport with mergify labels Aug 3, 2021
@michalpristas michalpristas self-assigned this Aug 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 3, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-03T07:55:52.290+0000

  • Duration: 72 min 25 sec

  • Commit: 18ace25

Test stats 🧪

Test Results
Failed 0
Passed 7012
Skipped 16
Total 7028

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7012
Skipped 16
Total 7028

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Like the use of the defer to perform the filter.

@michalpristas michalpristas merged commit afe17b8 into elastic:master Aug 3, 2021
mergify bot pushed a commit that referenced this pull request Aug 3, 2021
michalpristas added a commit that referenced this pull request Aug 4, 2021
(cherry picked from commit afe17b8)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
@amolnater-qasource
Copy link

amolnater-qasource commented Aug 30, 2021

Hi @EricDavisX
We are validating this PR in lieu of reported issue at #27057
We have revalidated this on 7.15.0 BC-2 and found it fixed now.

Observations:

  • No Failed to render configuration error logs observed when windows agent is installed with only System integration.

Build details:

Build: 43832
Commit: b7ad04c31d99f54fba754f1ad59dc8012e0fd4d1
Artifact Link: https://staging.elastic.co/7.15.0-642a73fa/downloads/beats/elastic-agent/elastic-agent-7.15.0-windows-x86_64.zip

Screenshot:
2

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify bug Team:Elastic-Agent Label for the Agent team
Projects
None yet
4 participants