feat: user precompiled libpcap

[kuisathaverat]

What does this PR do?

This PR removes the code related to cross-compile Libpcap before to cross-compile Packetbeat, the library is already compiled in the cross-build Docker image after we merge elastic/golang-crossbuild#91

Why is it important?

This reduces the time to build Packetbeat packages and make the process more robust due to does not have to download third-party resources.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
  - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

• merge feta: precompile libpcap golang-crossbuild#91

How to test this PR locally

cd packetbeat
make crosscompile

Related issues

Relates elastic/golang-crossbuild#63
Requires elastic/golang-crossbuild#91

[ph]

changes LGTM thanks for making it.

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: kuisathaverat commented: /test

• Start Time: 2021-06-02T09:36:14.414+0000

• Duration: 25 min 11 sec

• Commit: 78f7c0d

Trends 🧪

❕ Flaky test report

No test was executed to be analysed.

[urso]

CI still complains about the pcap.go :( . Sometimes import order is the problem. You might be able to fix the issue by running make check from within the packetbeat directory. It will likely fail, but update the pcap.go locally, so you can commit and push the fixed file.

[kuisathaverat]

I am not sure what this is about

(linux) I have no name!@40037d58abb6:~$ make -C packetbeat check
make: Entering directory '/go/src/github.com/elastic/beats/packetbeat'
>> fmt - go-licenser: Checking for missing headers
>> fmt - go-licenser: Adding missing headers
>> fmt - goimports: Formatting Go code
>> fmt - autopep8: Formatting Python code
No fields files for module applayer
No fields files for module tcp
No fields files for module udp
Generated fields.yml for packetbeat to /go/src/github.com/elastic/beats/packetbeat/fields.yml
Generated fields.yml for packetbeat to /go/src/github.com/elastic/beats/packetbeat/fields.yml
>> Building packetbeat.yml for linux/amd64
>> Building packetbeat.reference.yml for linux/amd64
>> Building packetbeat.docker.yml for linux/amd64
exec: go list -m
>> check: Checking source code for common problems
go: downloading github.com/elastic/go-lookslike v0.3.0
# github.com/tsg/gopacket/pcap
/go/pkg/mod/github.com/tsg/gopacket@v0.0.0-20200626092518-2ab8e397a786/pcap/pcap.go:20:10: fatal error: pcap.h: No such file or directory
 #include <pcap.h>
          ^~~~~~~~
compilation terminated.

[urso]

# github.com/tsg/gopacket/pcap
/go/pkg/mod/github.com/tsg/gopacket@v0.0.0-20200626092518-2ab8e397a786/pcap/pcap.go:20:10: fatal error: pcap.h: No such file or directory
 #include <pcap.h>
          ^~~~~~~~
compilation terminated.

How was libpcap made available in the docker image? The compiler can't find the header files. We either need to adapt the include path, or we are missing some files.

[mdelapenya]

@kuisathaverat I submitted a PR against your branch here: kuisathaverat#7

It seems there is a blank line in the packages block

[kuisathaverat]

/test

[kuisathaverat]

/test

[kuisathaverat]

/test

[kuisathaverat]

/test

[kuisathaverat]

/test