-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packaging] Bump golang-crossbuild version debian8 #23872
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
/packaging |
* upstream/master: (308 commits) [winlogbeat] Add support for sysmon v13 events 24 and 25 (elastic#24945) mergify: add backport label (elastic#25050) Add pod.ip in k8s metadata (elastic#25037) [elastic-agent] Use fleet.url for container cmd (elastic#25026) disable TestXPackEnabled flaky test in logstash metricbeat module (elastic#25034) Leverege leader election in agent k8s manifests (elastic#25016) libbeat/publisher/pipeline: expand monitoring (elastic#24700) libbeat: fix decode_json_fields config validation (elastic#24862) Remove make docs-preview instructions (elastic#25001) [Filebeat] Fix IPtables pipeline (elastic#24928) [DOCS] cd into correct directory before invoking mage. (elastic#17679) Add -buildmode=pie for supported platform (elastic#24964) Add agent's direcotry in k8s manifest generator (elastic#24987) [mergify] assign the original author (elastic#25007) Fix AWS module flaky tests (elastic#24852) [filebeat] Use fail_on_template_error on google_workspace and okta pagination (elastic#24967) Updated config to match defaults (elastic#25004) [Filebeat] Fix hardcoded amazonaws.com endpoint (elastic#24861) Add cloud.service.name to add_cloud_metadata (elastic#24993) [Ingest Manager] Expose processes and their metrics (elastic#24788) ...
@v1v it seems that the base image has an incorrect
It seems that jessie is still available under http://http.debian.net/debian, so maybe we should use this repository instead of http://archive.debian.org/debian. Official |
This pull request is now in conflicts. Could you fix it? 🙏
|
* upstream/master: packer cache support for the 7.x and 7.latestMinor branches (elastic#25091) Remove EventFetcher and EventsFetcher interface (elastic#25093) Update go-structform to 0.0.8 (elastic#25051) Update copy_fields.asciidoc (elastic#25053) [elastic-agent] ensure container is backwards compatible (elastic#25092) Add --fleet-server-service-token. Rename --fleet-server to --fleet-server-es. (elastic#25083) Add cgroup.cpuacct percentages (elastic#25057) Add tests for truncated and symlinked files in filestream input (elastic#24425) Fix panic when Hearbeat monitor initialization fails twice (elastic#25073) [Filebeat][httpjson] Change append transform to initiate new fields as a slice (elastic#25074) Osquerybeat: Result values type translation (elastic#25012) Update Osquerybeat spec to get it downloading from the correct artifactory path (elastic#25076) Fix changelog (elastic#25079) Strip Azure EventHub connection string in debug logs (elastic#25066) Change googlecloud to gcp in field names (elastic#25038) Bump stack version to 7.12.0 for testing (elastic#24957) packer-cache: cache the existing docker images on ARM and some more (elastic#25068) Disable logstash TestFetch flaky test (elastic#25044)
/test |
1 similar comment
/test |
@jsoriano , sorry that I missed this PR for a while.
IIUC, Jessie Long Term Support (LTS) ended in June 2020. elastic/golang-crossbuild#72 was the one that moved to debian-9 and changed to use I don't know the policy regarding what sources should be used, but I guess the changes to be done should be in the |
/test |
(cherry picked from commit cb8f4d3)
(cherry picked from commit cb8f4d3)
This PR proceeded without adding the tests and unfortunately Metricbeat, Packetbeat, and APM Server no longer run on CentOS 6 for 7.17 and 8.0. If you build the Dockerfile below you see the problem that occurs at runtime.
|
:/ I actually misunderstood that we were safe to move, what do we do here? |
@v1v is reverting the changes so we can get those Beats back to a working state for CentOS 6. Currently the 7.17.0 release is affected and the 8.0.0 RCs. Once we get back to a working state we can discuss how to safely move forward with this change to transition off of debian7 for building. |
I can't find a decision regarding 8.0 support for CentOS 6 in Beats/Agent. But if for 8.0 we are dropping support for Beats and Agent on CentOS/RHEL 6 then the changes might be OK for 8.0 and We should document the minimum supported GLIBC version for Beats and add the tests I mentioned for it. That will prevent us from accidentally moving to a new builder image in the future that goes beyond our minimum glibc version. That minimum supported GLIBC would basically be the oldest glibc version found in all the supported OSes. |
@andrewkroh CentOS EOL November 2020. with all honesty it should have been removed from our support matrix 6-12 months after that. No hard and fast rule about this but I'm trying to clean up our support matrix and set up a policy as such. I deprecated this support from the matrix in 8.0. the 7.17 matrix was just published. I can try and see if that can be modified. |
@nimarezainia does it mean that we are not supporting RHEL6 from 7.17 on? |
@v1v was it merged back to 7.17 and will it be part of a 7.17.1 release? |
IIIUC, Andrew mentioned that it should not be since it broke compatibility with centos6, see #23872 (comment) #30184 is the revert 8.0 and master are actually using this version, so a revert was proposed in :
But they are stalled waiting for the final call whether they should remain or merged |
yes correct. 7.17 is the last release. |
@v1v sorry I was talking about the revert. |
thank you all. So we will let users know that 7.17.1 is fixed. |
…3872) (elastic#29687)" This reverts commit d5e9cf5.
What does this PR do?
Bump version:
Why is it important?
As discussed offline to use debian 8 images
Failures
Command =
PACKAGES='+all linux/amd64 linux/386 linux/arm64 linux/armv7 windows/amd64 windows/386' mage package
Error