Cherry-pick #19205 to 7.x: [Elastic Agent] Support an application spec to be ran through service manager (eg. Endpoint) #19487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… manager (eg. Endpoint) (elastic#19205) * Initial spec parsing for endpoint. * Update comment. * Fix spec test. * Update code so it copies the entire input. * Fix ast test. * Merge agent-improve-restart-loop * Merge agent-endpoint-spec * Refactor core/plugin/app into mostly core/ and use core/plugin for different app types. * Work on endpoint service application. * More fixes. * Fix format and tests. * Fix some imports. * More cleanups. * Fix export comment. * Pass the program.Spec into the descriptor. * Fix some small issues with service app. * Fix lint and tests. * Remove the code no longer needed because of newer config format. * Fix rules and review. (cherry picked from commit ac51570)
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19205 to 7.x branch. Original message:
What does this PR do?
This splits the
pkg/core/plugin/appinto 2 distinct types of application typesprocess(which runs the application as a subprocess and passes the connection credentials through stdin) andservice(which runs the application as it is started by the service manager on the system and passes the connection credentials over a TCP socket defined in the spec file withservice: {port_number}.This updates the
endpoint.specfile to setservice: 6788so that thepkg/core/plugin/service.Applicationwill start the TCP connections credentials socket on 6788.This also moves some modules around outside of
pkg/core/pluginto justpkg/corekeepingpkg/core/plugin/*for the different application types. This also allows for better code re-use in some areas, as the 2 types have lots in common.This currently has a pre-req on #19171, so it shows in this diff.
Why is it important?
To enable support for Elastic Agent to control Endpoint as a service that is installed on the same machine.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.