-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint.spec that renders the endpoint program to be run by Agent #19171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ingest-management (Team:Ingest Management) |
Converted to draft until the final endpoint configuration that Elastic Agent will send is complete. |
Merged
4 tasks
ruflin
approved these changes
Jun 18, 2020
ph
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Jun 26, 2020
elastic#19171) * Initial spec parsing for endpoint. * Update comment. * Fix spec test. * Update code so it copies the entire input. * Fix ast test. * Remove the code no longer needed because of newer config format. (cherry picked from commit 7450d4e)
blakerouse
added a commit
that referenced
this pull request
Jun 26, 2020
…t program to be run by Agent (#19448) * Add endpoint.spec that renders the endpoint program to be run by Agent (#19171) * Initial spec parsing for endpoint. * Update comment. * Fix spec test. * Update code so it copies the entire input. * Fix ast test. * Remove the code no longer needed because of newer config format. (cherry picked from commit 7450d4e) * Fix logfile.
4 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
elastic#19171) * Initial spec parsing for endpoint. * Update comment. * Fix spec test. * Update code so it copies the entire input. * Fix ast test. * Remove the code no longer needed because of newer config format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
spec/endpoint.yml
that parses theelastic-agent.yml
into a configuration that is passed to Endpoint. This passes the entire input definition into the Endpoint configuration, allowing Agent not need need to worry about new keys.Fleet
andoutput
is also passed through directly to Endpoint.This does not include the code to actually perform the installation of Endpoint and run it, this is just step 1 of that process. Next branch will perform the installation, now that this branch instructs Elastic Agent that Endpoint should be ran.
Why is it important?
To support Elastic Agent running Endpoint.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs