Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #17966 to 7.x: Metricbeat add IIS module dashboards #18167

Merged
merged 1 commit into from
May 4, 2020
Merged

Cherry-pick #17966 to 7.x: Metricbeat add IIS module dashboards #18167

merged 1 commit into from
May 4, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented May 4, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #17966 to 7.x branch. Original message:

  • Enhancement

What does this PR do?

  • Adds dashboards to the metricbeat IIS module.
  • Fixes wrong mapped fields in application pool and webserver metricsets

Why is it important?

Useful to visualize the information retrieved.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshots

webserver

webserverprocess

website

application_pool

@narph
Metricbeat add IIS module dashboards (elastic#17966)
a03aea9 
* add iis dashboards

* update changelog

* modify dash

(cherry picked from commit c3dcfc7)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
@narph narph self-assigned this May 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@narph narph removed the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
ChrsMark
ChrsMark approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport lgtm!

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 4, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 2151
Skipped 522
Total 2673

@narph narph merged commit 08070d0 into elastic:7.x May 4, 2020
@narph narph deleted the backport_17966_7.x branch May 4, 2020 13:14
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @ChrsMark