Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metricbeat add IIS module dashboards #17966

Merged
merged 5 commits into from
May 4, 2020
Merged

Metricbeat add IIS module dashboards #17966

merged 5 commits into from
May 4, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Apr 24, 2020

  • Enhancement

What does this PR do?

  • Adds dashboards to the metricbeat IIS module.
  • Fixes wrong mapped fields in application pool and webserver metricsets

Why is it important?

Useful to visualize the information retrieved.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshots

webserver

webserverprocess

website

application_pool

@narph narph self-assigned this Apr 24, 2020
@narph narph added [zube]: In Review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.8.0 labels Apr 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@narph narph requested a review from sorantis April 24, 2020 13:51
sorantis
sorantis reviewed Apr 27, 2020
View reviewed changes
Copy link
Contributor

@sorantis sorantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there a way we could make users and cache related metrics more readable, e.g. with gauge view in TSVB?

@narph
Copy link
Contributor Author

narph commented May 3, 2020

webserver1

webserverrrocess

@narph narph requested a review from sorantis May 3, 2020 16:31
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 2992
Skipped 744
Total 3736

@narph narph merged commit c3dcfc7 into elastic:master May 4, 2020
@narph narph deleted the iis-dash branch May 4, 2020 09:58
narph added a commit to narph/beats that referenced this pull request May 4, 2020
@narph
Metricbeat add IIS module dashboards (elastic#17966)
a03aea9 
* add iis dashboards

* update changelog

* modify dash

(cherry picked from commit c3dcfc7)
@narph narph mentioned this pull request May 4, 2020
Merged
6 tasks
narph added a commit that referenced this pull request May 4, 2020
@narph
Metricbeat add IIS module dashboards (#17966) (#18167)
08070d0 
* add iis dashboards

* update changelog

* modify dash

(cherry picked from commit c3dcfc7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorantis sorantis sorantis approved these changes

Assignees

@narph narph

Labels
Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@narph @elasticmachine @sorantis @andresrc