-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Add cloud.account.id into events from aws module #13558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One question. Does it removes completely the ID from the event? I don't see a real need for it but, who knows, maybe it's mandatory for someone.
Ah! And I have to ask for the mandatory new binary size after adding more packages 😬
@sayden Thanks for the review 😬 No, it does not remove ID from the event. It only adds a new field for the cloud account. Regarding to the binary size, I'm actually not sure why this time, it added all files under |
sorry for the late comment, just a double check: Do we need to document any added permission for this to work? |
@exekias You are absolutely right! Yes, two more permissions are needed. I will push a separate PR to add it. Thanks! |
This PR is to add the ability to collect cloud.account.id and cloud.account.name into aws module. More user-friendly, account alias(For example: elastic-kaiyan-aws) is preferred than the account id(For example: 123456789).
cloud.account.name can be empty because for aws account, alias is not required.
closes #13551
How to test this:
With this change, if you enable any metricset under aws module and check in Kibana, you should see
cloud.account.id
in the event. If the account alias is set, thencloud.account.name
should exist as well in the new event.