Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Investigate on adding AccountID in aws module #13551

Closed
kaiyan-sheng opened this issue Sep 9, 2019 · 4 comments · Fixed by #13558
Closed

[Metricbeat] Investigate on adding AccountID in aws module #13551

kaiyan-sheng opened this issue Sep 9, 2019 · 4 comments · Fixed by #13558
Assignees
Labels
enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team v7.5.0

Comments

@kaiyan-sheng
Copy link
Contributor

AccountID will be very useful to have when users run metricbeat with more than one set of aws credentials from different accounts. Either account id or account name will be good to have.

cc @sorantis 👍

@kaiyan-sheng
Copy link
Contributor Author

@sorantis By looking at add_cloud_metadata https://www.elastic.co/guide/en/beats/metricbeat/current/add-cloud-metadata.html, I can see cloud.account.id under the AWS example is the actual id number, not the account name/alias. What do you think about adding both cloud.account.id and cloud.account.name? Will this work for infra-ui page?

@sorantis
Copy link
Contributor

@kaiyan-sheng cloud.account.id doesn't look user friendly, and I wonder if the user would be able to distinguish between different cloud ids when they navigate AWS inventory? cloud.account.name sounds more like it for Infra UI. cc @simianhacker

@kaiyan-sheng
Copy link
Contributor Author

@sorantis Yes cloud.account.name is definitely gonna be more user-friendly. But the account name/alias is optional I think for AWS so some accounts might not have a name. In that case, should the account name be the same as the account id instead? Or in the UI, we can put in the logic for if account.name is empty, then uses account.id?

@sorantis
Copy link
Contributor

@kaiyan-sheng Makes sense, so to answer your first question, yes, we probably need both fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team v7.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants