Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub deployment status instead of comment test deployments #589

Merged

Conversation

LukasKalbertodt
Copy link
Member

See commits. As per usual with these, I couldn't 100% test it beforehand. So it has to be merged and I will fix any bugs then.

@github-actions
Copy link

🚀 This PR was deployed at https://pr589.tobira.opencast.org. The deployment will be updated whenever someone pushes onto this PR's branch.

Copy link
Member

@JulianKniephoff JulianKniephoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@JulianKniephoff JulianKniephoff merged commit 46fc140 into elan-ev:master Nov 15, 2022
@LukasKalbertodt LukasKalbertodt deleted the improve-deploy-workflows branch November 15, 2022 11:55
@LukasKalbertodt
Copy link
Member Author

For the record, there is still one suboptimal thing about all this: When a PR is closed/merged, the environment is not properly cleaned up. So this list will just grow: https://github.com/elan-ev/tobira/settings/environments
However, that's not really a problem. There is already an issue tracking this: bobheadxi/deployments#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants