Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step: delete-env does not delete env #118

Closed
ai opened this issue Sep 5, 2022 · 1 comment · Fixed by #134
Closed

step: delete-env does not delete env #118

ai opened this issue Sep 5, 2022 · 1 comment · Fixed by #134

Comments

@ai
Copy link
Contributor

ai commented Sep 5, 2022

I create env by

      - name: Notify about new deployment
        uses: bobheadxi/deployments@v1
        id: deployment
        with:
          step: start
          token: ${{ secrets.GITHUB_TOKEN }}
          ref: ${{ github.head_ref }}
          env: preview-${{ github.event.number }}

Then I delete it by:

      - name: Clean from GitHub
        uses: bobheadxi/deployments@v1
        with:
          step: delete-env
          token: ${{ secrets.GITHUB_TOKEN }}
          env: preview-${{ github.event.number }}

But delete-env does not really delete env and only mark it as inactive.

Here is a log from GitHub Actions:

Run bobheadxi/deployments@v1
  with:
    step: delete-env
    token: ***
    env: preview-479
    debug: false
    auto_inactive: false
targeting ***/browsersl.ist
preview-479: found 1 existing deployments for env
preview-479.642582676: setting deployment (b04ae51d657ee0d1f192d7ae2659b791cbacc38b) state to "inactive"
preview-479: 1 deployments updated
preview-479.642582676: deleting deployment (b04ae51d657ee0d1f192d7ae2659b791cbacc38b)"
preview-479: 1 deployments deleted

But we still have preview-479 in the Environments page in Settings:

Снимок экрана от 2022-09-05 14-02-39

@devthejo
Copy link
Contributor

Here is a PR: #118

bobheadxi added a commit that referenced this issue Jan 20, 2023
fix #118

Co-authored-by: Robert Lin <robertlin1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants