Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all supported flags to KubeletConfiguration #644

Merged
merged 2 commits into from
Mar 20, 2019
Merged

Move all supported flags to KubeletConfiguration #644

merged 2 commits into from
Mar 20, 2019

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Mar 19, 2019 •
edited
Loading

Description

Move all supported flags to KubeletConfiguration (towards #156).

  • remaining flags are not supported yet
  • cosmetic improvements to test suite

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)

@errordeveloper
Copy link
Contributor Author

@rndstr FYI, this is towards #396, however it turned out we still have to use flags to set taints.

@errordeveloper errordeveloper force-pushed the generate-kubelet-config branch 5 times, most recently from ab75e50 to 16bf0a5 Compare March 19, 2019 23:30
@errordeveloper errordeveloper changed the title WIP: Move all supported flags to KubeletConfiguration Move all supported flags to KubeletConfiguration Mar 19, 2019
mumoshu
mumoshu previously approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much for your effort!

@errordeveloper errordeveloper force-pushed the generate-kubelet-config branch from 16bf0a5 to 499eaf6 Compare March 20, 2019 07:54
@errordeveloper
Update vendor
c228275
@errordeveloper
Move all supported flags to KubeletConfiguration
dd933da 
- remaining flags are not supported yet
- various improvements to test suite
@errordeveloper errordeveloper force-pushed the generate-kubelet-config branch from 499eaf6 to dd933da Compare March 20, 2019 07:54
@errordeveloper errordeveloper merged commit 85f2e46 into master Mar 20, 2019
@errordeveloper errordeveloper deleted the generate-kubelet-config branch March 20, 2019 08:15
@rndstr rndstr mentioned this pull request Apr 5, 2019
Merged
6 tasks
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
@wongma7
Merge pull request eksctl-io#644 from wongma7/helm-workflow
f541380 
Remove helm chart step from release github workflow and github registry step from container images workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@errordeveloper @mumoshu