Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add taints to the node on creation #396

Closed
mumoshu opened this issue Jan 6, 2019 · 4 comments
Closed

feat: add taints to the node on creation #396

mumoshu opened this issue Jan 6, 2019 · 4 comments
Assignees
Milestone

Comments

@mumoshu
Copy link
Contributor

mumoshu commented Jan 6, 2019

As @whereisaaron suggested in another issue at #394 (comment), this is necessary to avoid misplacing pods after the kubelet created the node resource but before the user adds a taint(whose purpose is to avoid the pods being scheduled!)

kubelet provides the --taints option to adds taints on node creation, which completely resolves this problem.

I'd suggest adding --taints or --node-taints to the command-line flags for create cluster and create nodegroup, and possibly in another PR taints or nodeTaints in another PR after #381 lands.

@mumoshu mumoshu changed the title feat: add user-configurable node taint that is added on the node on creation feat: add user-configurable node taint that is added to the node on creation Jan 9, 2019
@mumoshu mumoshu changed the title feat: add user-configurable node taint that is added to the node on creation feat: add taints to the node on creation Jan 9, 2019
@aparamon
Copy link

aparamon commented Jan 18, 2019

It is proposed to provide a more general feature of passing arbitrary kubelet options, similar to
EKS BootstrapArguments.

Specifying taints would indeed be very useful, e.g. for dedicated Load Balancer nodes: #440.

@errordeveloper
Copy link
Contributor

It'd be good to make use this change as an opportunity to switch over from flags to kubelet config. We already have config, we just need to start generating and move labels and some of the other flags into it.

@errordeveloper
Copy link
Contributor

There had been a few requests for this, so I might start working on this for the next release.

@errordeveloper errordeveloper added this to the 0.1.21 - v1alpha5 milestone Feb 13, 2019
@errordeveloper
Copy link
Contributor

We should switch to kubelet config files (#156) before implementing this.

torredil pushed a commit to torredil/eksctl that referenced this issue May 20, 2022
helm: provide an option to set extra volume tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants