-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add taints to the node on creation #396
Comments
It is proposed to provide a more general feature of passing arbitrary kubelet options, similar to Specifying taints would indeed be very useful, e.g. for dedicated Load Balancer nodes: #440. |
It'd be good to make use this change as an opportunity to switch over from flags to kubelet config. We already have config, we just need to start generating and move labels and some of the other flags into it. |
There had been a few requests for this, so I might start working on this for the next release. |
We should switch to kubelet config files (#156) before implementing this. |
helm: provide an option to set extra volume tags
As @whereisaaron suggested in another issue at #394 (comment), this is necessary to avoid misplacing pods after the kubelet created the node resource but before the user adds a taint(whose purpose is to avoid the pods being scheduled!)
kubelet provides the
--taints
option to adds taints on node creation, which completely resolves this problem.I'd suggest adding
--taints
or--node-taints
to the command-line flags forcreate cluster
andcreate nodegroup
, and possibly in another PRtaints
ornodeTaints
in another PR after #381 lands.The text was updated successfully, but these errors were encountered: