Detect CF-on-K8s in cf api
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6374ef to
9198c06
Compare
9198c06 to
42a8473
Compare
jdgonzaleza
approved these changes
Sep 30, 2021
|
Thanks @jdgonzaleza! I have added @dominicrobertsc as a second reviewer. |
This makes `cf api` able to detect the `cf-on-k8s` flag in the root endpoint response and persist this information in the config. This will allow us to enable CF-on-K8s-specific behaviour for every following command. We have introduced a new `selfcontained` integration suite which contains tests that do not need to be run against a cf deployment. Issue: cloudfoundry/cf-k8s-api#10 Co-authored-by: Danail Branekov <danailster@gmail.com> Co-authored-by: Giuseppe Capizzi <gcapizzi@pivotal.io> Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
42a8473 to
6d6be23
Compare
matt-royal
pushed a commit
that referenced
this pull request
Mar 1, 2023
Upgrades go from 1.18 to 1.19 Co-authored-by: Juan Diego Gonzalez <gojuan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
cf apiable to detect thecf-on-k8sflag in the root endpoint response and persist this information in the config. This will allow us to enable CF-on-K8s-specific behaviour for every following command.Issue: cloudfoundry/cf-k8s-api#10