This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Introduce "cf_on_k8s": true into the / response
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birdrock
suggested changes
Sep 28, 2021
tcdowney
approved these changes
Sep 29, 2021
Birdrock
approved these changes
Sep 29, 2021
Also introduce root response presenter and response type Issue: #10 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
50b7e62 to
e0dce04
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#10
What is this change about?
Introduce a
cf_on_k8sproperty into theGET /response which is always true in CF-on-K8S API. This property will be processed by the CLI to figure out that it is talking to CF-on-K8s rather than CF-on-VMs. See eirini-forks/cli#1 for details.The change is compatible with the CF-on-VMs CC API as the absence of that field defaults to
falseon the CLI side, i.e. CLI would know that it talks to CF-on-VMs without actually changing the CC API there.Does this PR introduce a breaking change?
No
Acceptance Steps
curl localhost:9000"cf_on_k8s": truein the response bodyTag your pair
@georgethebeatle