Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Adjusting failing Integration tests in CircleCI #570

Merged
merged 4 commits into from
Jun 22, 2022

Conversation

af-pwo
Copy link
Contributor

@af-pwo af-pwo commented Jun 22, 2022

[ADJUST] Diagnostic Report w/ Observation is a valid ressource, therefore it should check for 201

[DELETE] Unnecessary "prepare" tags

[DELETE] Negative flow tests that tested valid behaviour. Validation was done by cross checking profiles documentation via https://simplifier.net/ForschungsnetzCovid-19/~resources?category=Profile&fhirVersion=R4&sortBy=RankScore_desc

value.quantity - Blood Pressure- invalid values
value.quantity - Body Temperature- invalid values
value.quantity - Fi02- invalid values
value.quantity - Body Height- invalid values
valueCodeableConcept.coding[0].code - Pregnancy Status -random string
code.coding* - Observation Lab - missing
valueCodeableConcept.coding[0].system - History of Travel - random
valueCodeableConcept.coding[0].code - History of Travel - random string
component[0].code.coding[0].code - History of Travel - random string
component[0].code.coding[0].system - History of Travel - random url
component[1].code.coding[0].code - History of Travel - random string
component[1].code.coding[0].system - History of Travel - random url
component[2].code.coding[0].code - History of Travel - random string
component[2].code.coding[0].system - History of Travel - random url
component[3].code.coding[0].code - History of Travel - random string
component[3].code.coding[0].system - History of Travel - random url
component[4].code.coding[0].code - History of Travel - random string
component[4].code.coding[0].system - History of Travel - random url

[DELETE] Unnecessary Bug Trace - Body Height

[BUG] Unexpected 201 at History if Travel when:

component[0].code.coding[0].system - missing
component[1].code.coding[0].system - missing
component[2].code.coding[0].system - missing
component[3].code.coding[0].system - missing
component[4].code.coding[0].system - missing

#568

This attribute is mandatory according to https://simplifier.net/forschungsnetzcovid-19/historyoftravel. An error should be thrown, when it is missing.

[ADD] Comments to Bug Trace case in History of Travel.

@af-pwo af-pwo requested review from SevKohler and fwurzel June 22, 2022 08:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fwurzel fwurzel merged commit eb9d961 into develop Jun 22, 2022
@fwurzel fwurzel deleted the NUM-Deployment-Adjustments branch June 22, 2022 11:06
@fwurzel fwurzel restored the NUM-Deployment-Adjustments branch June 22, 2022 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants