-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Clean up the API constants for v4 #965
Conversation
0199c6b
to
f36e068
Compare
block by: edgexfoundry/go-mod-core-contracts#965 Signed-off-by: Ginny Guan <ginny@iotechsys.com>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 43.29% 43.71% +0.42%
==========================================
Files 112 111 -1
Lines 6860 6693 -167
==========================================
- Hits 2970 2926 -44
+ Misses 3646 3532 -114
+ Partials 244 235 -9 ☔ View full report in Codecov by Sentry. |
- Replace constant name "EchoRoute" with original "Route" - Remove unused ById API route constants edgexfoundry/edgex-go#2994 - Remove unused callback API route code edgexfoundry/device-sdk-go#1259 close edgexfoundry#956 Signed-off-by: Ginny Guan <ginny@iotechsys.com>
f36e068
to
bf174a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
relate: edgexfoundry/go-mod-core-contracts#965 Signed-off-by: Ginny Guan <ginny@iotechsys.com>
relate edgexfoundry/go-mod-core-contracts#965 Signed-off-by: Ginny Guan <ginny@iotechsys.com>
block by: edgexfoundry/go-mod-core-contracts#965 Signed-off-by: Ginny Guan <ginny@iotechsys.com>
Replace constant name "EchoRoute" with original "Route"
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)