Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clean up the API constants for v4 #965

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jinlinGuan
Copy link
Contributor

Replace constant name "EchoRoute" with original "Route"

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

jinlinGuan added a commit to jinlinGuan/edgex-go that referenced this pull request Dec 24, 2024
block by: edgexfoundry/go-mod-core-contracts#965

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 43.71%. Comparing base (80a711a) to head (bf174a4).

Files with missing lines Patch % Lines
clients/interfaces/mocks/AuthenticationInjector.go 0.00% 26 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
+ Coverage   43.29%   43.71%   +0.42%     
==========================================
  Files         112      111       -1     
  Lines        6860     6693     -167     
==========================================
- Hits         2970     2926      -44     
+ Misses       3646     3532     -114     
+ Partials      244      235       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Replace constant name "EchoRoute" with original "Route"
- Remove unused ById API route constants edgexfoundry/edgex-go#2994
- Remove unused callback API route code edgexfoundry/device-sdk-go#1259

close edgexfoundry#956

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 3954224 into edgexfoundry:main Jan 6, 2025
3 checks passed
@jinlinGuan jinlinGuan deleted the issue-956 branch January 6, 2025 02:23
jinlinGuan added a commit to edgexfoundry/go-mod-bootstrap that referenced this pull request Jan 6, 2025
relate: edgexfoundry/go-mod-core-contracts#965

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
jinlinGuan added a commit to jinlinGuan/device-sdk-go that referenced this pull request Jan 6, 2025
relate edgexfoundry/go-mod-core-contracts#965

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
jinlinGuan added a commit to jinlinGuan/edgex-go that referenced this pull request Jan 6, 2025
block by: edgexfoundry/go-mod-core-contracts#965

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants