Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the API constants in v4 #956

Closed
cloudxxx8 opened this issue Nov 25, 2024 · 0 comments
Closed

Clean up the API constants in v4 #956

cloudxxx8 opened this issue Nov 25, 2024 · 0 comments
Assignees
@jinlinGuan
Labels
enhancement New feature or request

Comments

@cloudxxx8
Copy link
Member

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for all

Description [REQUIRED]

We have two set of API constants in v3 for the transition from gorilla webtoolkit to echo
https://github.com/edgexfoundry/go-mod-core-contracts/blob/3c1c392b8b6fade824fdcda010aad97ce37a4762/common/echo_api_constants.go
https://github.com/edgexfoundry/go-mod-core-contracts/blob/3c1c392b8b6fade824fdcda010aad97ce37a4762/common/constants.go

In v4, we should clean up the redundant constants.

go-mod-core-contracts/common/echo_api_constants.go

Line 9 in 3c1c392

// TODO: Remove in EdgeX 4.0 and will use the original API constant names defined in constants.go

@cloudxxx8 cloudxxx8 added the enhancement New feature or request label Nov 25, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Technical WG Nov 25, 2024
@jumpingliu jumpingliu moved this from New Issues to Release Backlog in Technical WG Dec 4, 2024
@jackchenjc jackchenjc assigned jackchenjc and unassigned jinlinGuan Dec 11, 2024
@cloudxxx8 cloudxxx8 assigned jinlinGuan and unassigned jackchenjc Dec 14, 2024
jinlinGuan added a commit to jinlinGuan/go-mod-core-contracts that referenced this issue Dec 24, 2024
@jinlinGuan
feat: Clean up the API constants for v4
f36e068 
Replace constant name "EchoRoute" with original "Route"

close edgexfoundry#956

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
@github-project-automation github-project-automation bot moved this from Release Backlog to Odessa Done in Technical WG Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinlinGuan jinlinGuan

Labels
enhancement New feature or request
Projects
Technical WG
Status: Odessa Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cloudxxx8 @jackchenjc @jinlinGuan