Tighter test now that all.equal.data.table dispatches to nanoduration's all.equal() method #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s all.equal() method
|
That looks fine at a glance. And I presume you can ensure that the modified version is happy with the upcoming |
|
Yep, this PR was developed with dev installed. You did remind me to check & be sure this also passes with CRAN data.table in case you wanted to release early -- confirmed. |
|
Can I ask you to quickly add a ChangeLog entry too? Same format as eg for your RProtoBuf changes here (with of course an email of your chosing, at work or home or ...) |
|
Actually, this reminds me that I had promised @kalibera an update at CRAN as his (earlier) PR is needed there too. I shall look into this. (But not before CRAN gets back to me re |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
We could also loosen the tolerance but a 1-second difference looks meaningful to me. Is the code WAI?