Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revdep dtts test error after all.equal dispatch #6285

Closed
tdhock opened this issue Jul 16, 2024 · 3 comments
Closed

revdep dtts test error after all.equal dispatch #6285

tdhock opened this issue Jul 16, 2024 · 3 comments
Assignees
Labels
revdep Reverse dependencies
Milestone

Comments

@tdhock
Copy link
Member

tdhock commented Jul 16, 2024

#4546 broke revdep dtts https://rcdata.nau.edu/genomic-ml/data.table-revdeps/analyze/2024-07-16/

* checking tests ...
  Running 'tinytest.R'
 ERROR
Running the tests in 'tests/tinytest.R' failed.
Last 13 lines of output:
   diff| Column 'index': Mean relative difference: 0.01851852
  ----- FAILED[attr]: test_dtts.R<128--128>
   call| expect_equal(align(dt1, t2, start = as.nanoduration(0), end = one_second_duration, 
   call| -->    eopen = FALSE), dt1[seq(5, 50, 5)])
   diff| Column 'index': Mean relative difference: 0.01785714
  ----- FAILED[attr]: test_dtts.R<139--139>
   call| expect_equal(align(dt1, t2, start = -one_second_period, tz = "America/New_York"), 
   call| -->    dt1[seq(4, 49, 5)])
   diff| Column 'index': Mean relative difference: 0.01851852
  ----- FAILED[attr]: test_dtts.R<149--149>
   call| expect_equal(align(dt1, t2, end = one_second_period, eopen = FALSE, 
   call| -->    tz = "America/New_York"), dt1[seq(5, 50, 5)])
   diff| Column 'index': Mean relative difference: 0.01785714
  Error: 4 out of 102 tests failed
  Execution halted

@MichaelChirico @ben-schwen can you please investigate?

@MichaelChirico
Copy link
Member

Sent eddelbuettel/dtts#18

@tdhock tdhock self-assigned this Jul 17, 2024
@MichaelChirico MichaelChirico added this to the 1.16.0 milestone Jul 17, 2024
@eddelbuettel
Copy link
Contributor

Just to reiterate -- the new dtts is at CRAN now so no worries on your end:

image

@MichaelChirico
Copy link
Member

Thanks Dirk! Our protocol here is to wait for a ➕ report from the revdeps server; I see that now:

https://rcdata.nau.edu/genomic-ml/data.table-revdeps/analyze/2024-07-19/

image

So closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revdep Reverse dependencies
Projects
None yet
Development

No branches or pull requests

3 participants