[bug-OpenMage#323] Concatenated param for getSelect()->order() is mis…

…sing a space
edannenberg · Aug 17, 2020 · 1c9202f · 1c9202f
1 parent a173201
commit 1c9202f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/code/core/Mage/Cron/Model/Resource/Schedule/Collection.php b/app/code/core/Mage/Cron/Model/Resource/Schedule/Collection.php
@@ -51,7 +51,7 @@ public function _construct()
      */
     public function orderByScheduledAt($dir = self::SORT_ORDER_ASC)
     {
-        $this->getSelect()->order('scheduled_at', $dir);
+        $this->getSelect()->order('scheduled_at ' . $dir);
         return $this;
     }
 }
diff --git a/app/code/core/Mage/Reports/Model/Resource/Order/Collection.php b/app/code/core/Mage/Reports/Model/Resource/Order/Collection.php
@@ -174,7 +174,7 @@ protected function _prepareSummaryLive($range, $customStart, $customEnd, $isFilt
                 Mage_Sales_Model_Order::STATE_PENDING_PAYMENT,
                 Mage_Sales_Model_Order::STATE_NEW)
             )
-            ->order('range', Zend_Db_Select::SQL_ASC)
+            ->order('range ' . Zend_Db_Select::SQL_ASC)
             ->group($tzRangeOffsetExpression);
 
         $this->addFieldToFilter('created_at', $dateRange);

diff --git a/app/code/core/Mage/XmlConnect/Model/Resource/Images.php b/app/code/core/Mage/XmlConnect/Model/Resource/Images.php
@@ -54,7 +54,7 @@ public function repairOrder(Mage_Core_Model_Abstract $image)
 
         $select = $this->_getWriteAdapter()->select()->from($this->getMainTable(), array('image_id'))
             ->where('application_id=:application_id AND image_type=:image_type')
-            ->order('order', Varien_Data_Collection::SORT_ORDER_ASC);
+            ->order('order ' . Varien_Data_Collection::SORT_ORDER_ASC);
 
         $result = $this->_getWriteAdapter()->fetchCol($select, $bind);
         $imageModel = Mage::getModel('xmlconnect/images');