Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong usage of getSelect()->order() method #323

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Fixes wrong usage of getSelect()->order() method #323

merged 1 commit into from
Aug 16, 2017

Conversation

sreichel
Copy link
Contributor

Fixed order() methods where direction is used as (non-existing) second parameter.

https://github.com/OpenMage/magento-lts/blob/1.9.3.x/lib/Zend/Db/Select.php#L577-L587

/**
 * Adds a row order to the query.
 *
 * @param mixed $spec The column(s) and direction to order by.
 * @return Zend_Db_Select This Zend_Db_Select object.
 */
public function order($spec)
{
    if (!is_array($spec)) {
        $spec = array($spec);
    }

Used $ grep -rn "order('[a-z_]*'," ./app/code/core/Mage/ ... so that should be all.

@colinmollenhour colinmollenhour merged commit eb471e1 into OpenMage:1.9.3.x Aug 16, 2017
@sreichel sreichel deleted the hotfix/wrong-select-order-parameter branch August 16, 2017 20:43
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Dec 6, 2017
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Dec 6, 2017
@sreichel sreichel added the bug label Jan 11, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Feb 28, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Mar 20, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Jul 17, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Sep 19, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Feb 14, 2019
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Apr 1, 2019
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 22, 2019
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Oct 25, 2019
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants