Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material] Layout passes renderers props down to children #1298

Merged
merged 1 commit into from
Mar 18, 2019
Merged

[material] Layout passes renderers props down to children #1298

merged 1 commit into from
Mar 18, 2019

Conversation

edgarmueller
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 89.193% when pulling 01ea986 on edgarmueller:fix/layout-renderers-prop into cb71f96 on eclipsesource:master.

@edgarmueller edgarmueller requested a review from eneufeld March 18, 2019 15:52
eneufeld
eneufeld approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests would be great

@edgarmueller edgarmueller mentioned this pull request Mar 18, 2019
Closed
@edgarmueller
Copy link
Contributor Author

I've created a follow-up issue which is #1299

@edgarmueller edgarmueller merged commit 6e50033 into eclipsesource:master Mar 18, 2019
@edgarmueller edgarmueller mentioned this pull request Mar 19, 2019
Closed
@edgarmueller edgarmueller added this to the 2.2.2 milestone Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarmueller @coveralls @eneufeld