Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout renderer should pass renderers property to children #1295

Closed
edgarmueller opened this issue Mar 13, 2019 · 1 comment
Closed

Layout renderer should pass renderers property to children #1295

edgarmueller opened this issue Mar 13, 2019 · 1 comment
Assignees
@edgarmueller
Labels
material react
Milestone
2.2.2

Comments

@edgarmueller
Copy link
Contributor

edgarmueller commented Mar 13, 2019 •
edited
Loading

Describe the bug
The JsonForms component allows a renderers property to be specified which constrains the set of renderers that are considered during rendering, but the layout renderers do not pass that property to their children, hence the initial constrains become obsolete.

To Reproduce

  1. Use the material renderer set with custom renderers for controls.
  2. Specify <JsonForms renderers={materialRenderers} />, which should use default material renderers for controls

Expected behavior
If the renderers property has been specified it should be considered for alll nested elements as well.
Used Setup (please complete the following information):

  • Framework: react
  • RendererSet: material
@edgarmueller edgarmueller added this to the 2.2.2 milestone Mar 13, 2019
@edgarmueller edgarmueller self-assigned this Mar 13, 2019
@edgarmueller
Copy link
Contributor Author

Fixed via #1298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgarmueller edgarmueller

Labels
material react
Projects
None yet
Milestone
2.2.2
Development

No branches or pull requests
1 participant
@edgarmueller