Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the multiplexer on window reload/close #11810

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Remove the multiplexer on window reload/close #11810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/core/src/electron-main/messaging/electron-messaging-contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ export class ElectronMessagingContribution implements ElectronMainApplicationCon
}
});

sender.once('did-navigate', () => multiplexer.onUnderlyingChannelClose({ reason: 'Window was refreshed' })); // When refreshing the browser window.
sender.once('destroyed', () => multiplexer.onUnderlyingChannelClose({ reason: 'Window was closed' })); // When closing the browser window.
sender.once('did-navigate', () => this.disposeMultiplexer(sender.id, multiplexer, 'Window was refreshed')); // When refreshing the browser window.
sender.once('destroyed', () => this.disposeMultiplexer(sender.id, multiplexer, 'Window was closed')); // When closing the browser window.
const data = { channel: mainChannel, multiplexer };
this.windowChannelMultiplexer.set(sender.id, data);
return data;
Expand All @@ -93,6 +93,11 @@ export class ElectronMessagingContribution implements ElectronMainApplicationCon
return new ElectronWebContentChannel(sender);
}

protected disposeMultiplexer(windowId: number, multiplexer: ChannelMultiplexer, reason: string): void {
multiplexer.onUnderlyingChannelClose({ reason });
this.windowChannelMultiplexer.delete(windowId);
}

onStart(): void {
for (const contribution of this.messagingContributions.getContributions()) {
contribution.configure(this);
Expand Down