Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the multiplexer on window reload/close #11810

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

FinnChen
Copy link
Contributor

What it does

Fixes #11600.

How to test

  • Run the electron example
  • Press cmd+r to reload the window
  • Click the New Window in the menu, and it does not work.

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the changes work well for me, and fix an issue where I was unable to perform open folder (which creates a new window) on electron 👍

@vince-fugnitto vince-fugnitto added the electron issues related to the electron target label Nov 14, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well 👍

@vince-fugnitto vince-fugnitto merged commit b2c52e2 into eclipse-theia:master Nov 24, 2022
@vince-fugnitto vince-fugnitto added this to the 1.32.0 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create new window after reload the current empty window
3 participants