Fixed issue with language server extensions #11771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Bozzini <federico.bozzini@gmail.com>
6d0f7f5 to
9cd7a91
Compare
There was a problem hiding this comment.
@federicobozzini I confirmed that plugins are now properly loaded in both the browser and electron applications 👍
Side Note
I'm yet to use web extensions but I believe they should only work in the remote or browser context correct? It seems as though we still load some content but not the command handler for instance. I verified by creating a hello-world web extension from the vscode generator:
The browser will correctly execute the hello world command while electron will throw an error:
vince-fugnitto
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
It fixes the error discussed at #11752 . Language server extensions were not loaded properly. With this PR they are considered backend extension and loaded correctly.
How to test
Start Vanilla theia and observe the logs. All 76 builtin are loaded.
Review checklist
Reminder for reviewers