Improved support for VsCode frontend extensions #11752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/plugin-ext-vscode/src/node/plugin-vscode-directory-handler.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Federico Bozzini <federico.bozzini@gmail.com>
cd5e7f9 to
b38079f
Compare
colin-grant-work
approved these changes
Oct 13, 2022
|
@federicobozzini I believe this pull-request should be reverted or fixed, it breaks the loading of most plugins (ex: out of 76 builtins only 23 are actually loaded). |
|
@vince-fugnitto I didn't notice any error on my local Theia setup but I'll quickly investigate this. If I will not find any good fix I'll open a PR to revert this change. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Looking at the logs it looks like web vs-code extensions are still classified as backend extension. Shouldn't they be treated the same as theia plugins where there is a clear discrimination between backend and frontend plugins?
How to test
Installing a web vs-code extension should show a difference in the logs. There are more differences in how backend and frontend plugins are treated but this PR is not meant to address any specific issue, but more to make vs-code extension support future proof.
Review checklist
Reminder for reviewers