-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filepath to main.ts in customizing_cli.md #271
Conversation
@msujew: I'm new to TypeScript, Langium, and to the etiquette regarding pull requests open-source projects (this would be my first contribution). I hope that this change is correct, and that it is OK for me to open a Pull Request like this. I am not sure if there are any conventions regarding branch naming, commit messages, or PR descriptions which I need to adhere to. Please feel free to give me feedback or make changes to this PR! |
Do I need to register with the eclipse foundation to be able to merge changes? |
Hi @mnikander , thanks for the contribution! With regards to etiquette, naming, and such this is perfectly fine, looks good to me, and in fact this was an outdated reference that needed to be freshened up; thanks for catching that! The one remaining blocker is that you'll need to sign the Eclipse Contributor Agreement for this project, & double check that you using the same email as the one on your commit. Once that's all done you should be pretty much good to go here (pending an approval). |
@montymxb: Thanks for the reply! I signed the Eclipse Contributer Agreement and refreshed that stage in the CI, so that's covered! I'll wait for feedback and hopefully an approval. |
I did a |
|
I rebased onto the current main |
Hi @Lotes I saw that you were the most recent person to review a pull request in this repo. Can you review this PR for me? Is there anything I can improve here? :) |
Thanks for your contribution. I think the Can you add a footnote (or similar) to all occurrences, pointing out that this path varies from the provided repository? WDYT about it? |
@Lotes we could also rename the index.ts to align with the current generation state? That would save us having to note it everywhere else. |
@montymxb @mnikander Then, this change is ok. Let's rename it in Minilogo as well. |
I'm just trying to do so: TypeFox/langium-minilogo#16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Lotes I don't have write access, so I can't merge. Feel free to merge! |
The CLI section and generate of the minilogo tutorial reference a file 'src/cli/index.ts' which does not exist. Updated the path to 'src/cli/main.ts' instead. Make the path explicit, even when it is mentioned the second time, to avoid possible confusion with other 'main.ts' files.