-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename index.ts to main.ts #16
Conversation
@mnikander There's no 3.0.1 release of Langium, did you mean 3.1.0? |
I ran
So I assumed it was a newer langium version as well (not just the cli). My bad. |
96a9ae3
to
0c52f0c
Compare
I removed my erroneous change to the langium version in the package.json. I could also just remove the second commit entirely, which contains the changes that resulted from generating with the current langium version. What do you think? |
Here is what I checked / tested so far:
Is there anything else I or you guys need to check to ensure minilogo works correctly, with these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I also tested the build and other scripts. It works as it should. @montymxb any words against merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing against this on my end, this looks good now, thanks for the changes @mnikander ! We'll take this in.
You're welcome! Thank you for your feedback and guidance! |
Changes: