Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename index.ts to main.ts #16

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

mnikander
Copy link
Contributor

@mnikander mnikander commented Jan 21, 2025

Changes:

  • rename index.ts to main.ts to be consistent with current langium projects
  • update import statements accordingly
  • add the source changes that happened when building the project with the current Langium version

@mnikander
Copy link
Contributor Author

@Lotes and @montymxb I am able to compile it locally with these changes. I'm not sure what I would need to check, to ensure that it actually works in all the places where it is used. Can one of you verify it's alright, or tell me what I need to check?

@montymxb
Copy link
Member

@mnikander There's no 3.0.1 release of Langium, did you mean 3.1.0?

@mnikander
Copy link
Contributor Author

mnikander commented Jan 21, 2025

I ran npm run build and several files had this line marked as a change:

This file was generated by langium-cli 3.0.1.

So I assumed it was a newer langium version as well (not just the cli). My bad.

@mnikander mnikander force-pushed the rename_index_to_main branch from 96a9ae3 to 0c52f0c Compare January 21, 2025 11:05
@mnikander
Copy link
Contributor Author

mnikander commented Jan 21, 2025

I removed my erroneous change to the langium version in the package.json.

I could also just remove the second commit entirely, which contains the changes that resulted from generating with the current langium version. What do you think?

@mnikander
Copy link
Contributor Author

mnikander commented Jan 21, 2025

Here is what I checked / tested so far:

  • npm run build executes without errors or warnings
  • when comparing the compiled code from the main branch and this fixed branch, npm run generate:test and npm run generate:logo print absolutely identical output to the console (I dumped the output to a file and did a diff)

Is there anything else I or you guys need to check to ensure minilogo works correctly, with these changes?

Copy link
Contributor

@Lotes Lotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also tested the build and other scripts. It works as it should. @montymxb any words against merging?

Copy link
Member

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: Nothing against this on my end, this looks good now, thanks for the changes @mnikander ! We'll take this in.

@montymxb montymxb merged commit 397737b into TypeFox:main Jan 22, 2025
@mnikander mnikander deleted the rename_index_to_main branch January 22, 2025 14:27
@mnikander
Copy link
Contributor Author

You're welcome! Thank you for your feedback and guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants