This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Add DDS provider #61

Merged

SebastianSchildt merged 12 commits into eclipse-kuksa:main from boschglobal:feature/DDS_feeder

Mar 29, 2023

Contributor

lukasmittag commented Feb 28, 2023

No description provided.

Contributor Author

lukasmittag commented Feb 28, 2023

lukasmittag marked this pull request as draft

February 28, 2023 15:17

Contributor Author

lukasmittag commented Feb 28, 2023

tests are missing as of now. Will be added in another commit.

AkhilTThomas force-pushed the feature/DDS_feeder branch from 89cd50b to 849ded8 Compare

March 2, 2023 08:43

lukasmittag force-pushed the feature/DDS_feeder branch 4 times, most recently from 3af806d to 0f0b0c0 Compare

March 6, 2023 13:11

lukasmittag force-pushed the feature/DDS_feeder branch from 6067191 to 86a86f4 Compare

March 16, 2023 08:49

lukasmittag marked this pull request as ready for review

March 16, 2023 12:34

lukasmittag added the DDS Feeder label

erikbosch reviewed

View reviewed changes

dds2val/tests/integration/feeder/test_ddsfeeder_int.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/src/ddsfeeder.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/tests/integration/feeder/test_ddsfeeder_int.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/tests/integration/feeder/test_ddsfeeder_int.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/src/README.md Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/src/ddsfeeder.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/src/README.md Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/src/OverallSequence.puml Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/__init__.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/src/databroker.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/src/ddsfeeder.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/src/idls/NavSatStatus.idl Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/src/idls/vss/setup.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/src/mapping.yml Outdated Show resolved Hide resolved

erikbosch suggested changes

View reviewed changes

Contributor

erikbosch left a comment

what I have done:

Reviewed the code
Succeeded running unit tests
Succeeded getting data sent to databroker (after changing import path as shown in comment)

Apart from the import (which either should be fixed, or someone else check that current setup works for them) the rest is minor items where not necessarily everything needs to be fixed.

erikbosch mentioned this pull request

Restructure Python-based feeders #62

Closed

lukasmittag force-pushed the feature/DDS_feeder branch from 5c0ca30 to 6dc3bc1 Compare

March 20, 2023 15:27

erikbosch reviewed

View reviewed changes

dds2val/src/make_executable.sh Outdated Show resolved Hide resolved


          Code for DDS Feeder and containerization

ac63c2a

lukasmittag added 4 commits

March 21, 2023 11:11


          make src a python module to be imported in tests

65ccb50


          Add integration and unit tests

bc9d3a1


          Add missing license headers

3c53ec5


          Create CI for DDS feeder

b69dfbb

Build the docker image for amd64 and arm64
Run the provided tests for dds feeder

Update kuksa_dds_feeder.yml

Add setup for build

Add separate build for arm64 amd64 to CI

fix typo in CI file

Fix typo in dds tests setup

Add generation of idls python modules

Start databroker instance for integration test

Update Dockerfile

Create make_executable.sh

Update make_executable.sh

lukasmittag force-pushed the feature/DDS_feeder branch from a85bdf1 to c65aee5 Compare

March 21, 2023 10:14

lukasmittag added 5 commits

March 22, 2023 09:14


          Update documentation

599567b


          Restructure and renaming

fd5bf25


          Update kuksa_dds_feeder.yml

fe1740a


          Update documentation

834e116


          Restructure and renaming

571e622

lukasmittag force-pushed the feature/DDS_feeder branch from 6563d96 to 571e622 Compare

March 22, 2023 08:18

lukasmittag requested a review from erikbosch

March 22, 2023 08:18

erikbosch reviewed

View reviewed changes

dds2val/OverallSequence.puml Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/ddsprovider.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/tests/conftest.py Show resolved Hide resolved

erikbosch approved these changes

View reviewed changes

Contributor

erikbosch left a comment

Looks good, only some minors that we possibly could ignore.

Possibly we should also mention ddsprovider on top level README (https://github.com/boschglobal/kuksa.val.feeders/blob/feature/DDS_feeder/README.md)

I did start ddprovider natively as well as from docker and did test from dds2val directory and all succeeded.

Contributor Author

lukasmittag commented Mar 22, 2023

Looks good, only some minors that we possibly could ignore.

Possibly we should also mention ddsprovider on top level README (https://github.com/boschglobal/kuksa.val.feeders/blob/feature/DDS_feeder/README.md)

I did start ddprovider natively as well as from docker and did test from dds2val directory and all succeeded.

@SebastianSchildt should we merge or would you like to see a config file?

erikbosch reviewed

View reviewed changes

dds2val/README.md Outdated Show resolved Hide resolved


          Update configuration parameters

lukasmittag force-pushed the feature/DDS_feeder branch from f851c61 to 4340376 Compare

March 24, 2023 09:20

lukasmittag changed the title ~~Add DDS feeder~~ Add DDS provider

lukasmittag requested a review from erikbosch

March 27, 2023 07:04

erikbosch reviewed

View reviewed changes

dds2val/README.md Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/ddsprovider.py Outdated Show resolved Hide resolved

erikbosch reviewed

View reviewed changes

dds2val/README.md Outdated Show resolved Hide resolved

erikbosch approved these changes

View reviewed changes

Contributor

erikbosch left a comment

Some minor ones. Did a test run with Docker and it works as expected


          Update environment varibales which can be set

932df74

SebastianSchildt merged commit e620e9b into eclipse-kuksa:main

erikbosch deleted the feature/DDS_feeder branch

September 29, 2023 09:36

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels